Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal to fix the checkout branch when a local branch exists and contains slashes in its name #163

Merged
merged 1 commit into from
Oct 20, 2021

Conversation

crazy-matt
Copy link
Contributor

Check list

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation

Description

The last change introduced in order to track a remote branch create a bug when the branch name contains slashes and the branch already exists locally.

Type of change

  • Bug fix
  • New feature
  • Refactor
  • Breaking change
  • Documentation change

Test environment

  • Shell
    • bash
    • zsh
    • fish
  • OS
    • Linux
    • Mac OS X
    • Windows
    • Others:

...when a local branch exists and contains slashes in its name.
@crazy-matt crazy-matt mentioned this pull request Aug 31, 2021
5 tasks
@dides82
Copy link

dides82 commented Oct 8, 2021

Hi,
I had the same behavior: impossible to track a remote branch (I would end up in detached HEAD) and impossible to checkout local branches with slashes (it would create a new branch tracking my local branch 😒).
This fix solves the problem for me 👍 Thanks

@wfxr
Copy link
Owner

wfxr commented Oct 20, 2021

@crazy-matt Sorry for the too late reply. I tested it and it worked fine. Thanks for your contribution!

@wfxr wfxr merged commit bb55cf3 into wfxr:master Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants