fix: gd show empty preview when path has spaces #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cjappl Can you help fix the |
|
I'm going to merge this, as I tried for a bit yesterday to fix in fish and was having issues. Made #206 to track it. I noticed that this issue happens in both gd and ga for fish, you should check that |
|
Thank you @cjappl.
|
|
Thanks for the fix! Consider the following directory structure: Working directory is
|
10 tasks
carlfriedrich
added a commit
to carlfriedrich/forgit
that referenced
this pull request
Jan 30, 2023
This had been fixed before in wfxr#189, but obviously the patch broke support for whitespaces in file names. That was fixed in wfxr#204, which in turn broke support for renames again. Unfortunately we cannot support both cases together with the existing 'xargs' implementation, because the arguments are interpreted either as one single file name (which breaks renames, because we have two files passed in this case) or as separate file names (which breaks whitespace support, because git would interpret each word of the file name as a separate file). This patch moves away from xargs and stores the file names in a bash array instead. This makes it possible to pass them to "git diff" quoted one by one using the "${array[@]}" notation.
15 tasks
carlfriedrich
added a commit
that referenced
this pull request
Feb 28, 2023
This had been fixed before in #189, but obviously the patch broke support for whitespaces in file names. That was fixed in #204, which in turn broke support for renames again. Prepare the list of file names with the null-character \0 as a delimiter, so that we can use "xargs -0" to read it. This makes renames as well as filenames with spaces work correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check list
Description
See #203
Type of change
Test environment