Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: gsp does not work outside the root directory #386

Merged
merged 1 commit into from
Apr 26, 2024
Merged

Conversation

sandr01d
Copy link
Collaborator

Check list

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation

Description

gsp only works when executing it from the repository's root directory. This commit fixes this by passing the root directory to the git ls-files command we use to determine the files that can be stashed, similarly to how we do it in _forgit_reset_head.

Type of change

  • Bug fix
  • New feature
  • Refactor
  • Breaking change
  • Documentation change

Test environment

  • Shell
    • bash
    • zsh
    • fish
  • OS
    • Linux
    • Mac OS X
    • Windows
    • Others:

@wfxr
Copy link
Owner

wfxr commented Apr 26, 2024

Thank you @sandr01d, There is a similar issue I found. Could you help fix this too?

@sandr01d
Copy link
Collaborator Author

Thank you @sandr01d, There is a similar issue I found. Could you help fix this too?

Sure, I'll take a look

@sandr01d sandr01d merged commit 6f212fd into master Apr 26, 2024
7 checks passed
@sandr01d sandr01d deleted the gsp-subdir branch April 26, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants