Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

inplace_function: unit test for functor copy-assignment that throws #118

Closed
Quuxplusone opened this issue Dec 5, 2017 · 0 comments
Closed

inplace_function: unit test for functor copy-assignment that throws #118

Quuxplusone opened this issue Dec 5, 2017 · 0 comments
Assignees
@Quuxplusone

Comments

@Quuxplusone
Copy link
Contributor

On #116 @Voultapher writes:

@Quuxplusone thanks for your feedback so far! Something I noticed looking at the libcxx implementation, they seem to set their version of a vtable to 0, aka empty state, whenever they are about to copy or move. My best guess is, that its stack unwinding related. Can you come up with a test of a throwing copy assignment, that checks if the cleanup is done right?

I have been procrastinating on this. Creating this issue now so that it will not fall through the cracks when #116 is closed/merged.
@Quuxplusone Quuxplusone self-assigned this Dec 5, 2017
Quuxplusone added a commit to Quuxplusone/SG14 that referenced this issue Jan 19, 2018
@Quuxplusone
Add tests for functors with throwing copy-constructors.
bcf4ad9 
And with deleted assignment operators, since functor assignment
should never be invoked by `inplace_function`. (Lambdas don't have
assignment operators, for example, and we want to store lambdas.)

Fixes WG21-SG14#118.
@Quuxplusone Quuxplusone mentioned this issue Jan 19, 2018
Closed
Quuxplusone added a commit to Quuxplusone/SG14 that referenced this issue Jan 19, 2018
@Quuxplusone
inplace_function: Add tests for functors with throwing copy-construct…
fde0639 
…ors.

And with deleted assignment operators, since functor assignment
should never be invoked by `inplace_function`. (Lambdas don't have
assignment operators, for example, and we want to store lambdas.)

Fixes WG21-SG14#118.
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Quuxplusone Quuxplusone

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Quuxplusone