feat(drift-database): Shifted from shared prefs to drift for Exercises #453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it easier to understand the diffs
This is now separated into individual tables and methods so that they can be tested separately
handleUpdateExerciseFromApi should now be faster and save up on some requests. Ideally we would pre-populate the database with all exercises on first run, or even just ship it pre-filled
This wasn't really needed, we can just filter exercises by their variationID
We now dependency inject the database for the whole exercise provider, this makes our lives a bit easier
# Conflicts: # lib/main.dart # lib/providers/exercises.dart # lib/widgets/workouts/day.dart # pubspec.lock # pubspec.yaml
# Conflicts: # lib/widgets/add_exercise/steps/step2variations.dart # pubspec.lock
The documents folder is suggested for files that can't be generated by the application itself
This should be expanded later to allow to re-fetch all available exercises, etc.
rolandgeider
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (Proposed Changes)
Link to the issue :
Tests
Please make sure to add tests when implementing new features.
Checklist
Please check that the PR fulfills all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).