Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing Dismissible for better discoverability #459

Merged
merged 6 commits into from
Jan 23, 2024

Conversation

12people
Copy link
Contributor

Description (Proposed Changes)

  • Removing Dismissible on the nutrition and meal screens for better discoverability
  • Different button layouts for nutrition and meal screens, to compensate for removing Dismissible
  • New icon for toggling details
  • Adjusted padding
  • (Removing Dismissible on the weight and measurement screens is planned, but I'm having trouble adjusting tests to make deletion work.)

Checklist

Please check that the PR fulfills all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • Set a 100 character limit in your editor/IDE to avoid white space diffs in the PR
  • Tests for the changes have been added (for bug fixes / features)
  • Added yourself to AUTHORS.md
  • Updated/added relevant documentation (doc comments with ///).
  • Added relevant reviewers.

@rolandgeider rolandgeider merged commit 2dc08a1 into wger-project:master Jan 23, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants