Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature - contribue exercise suggestion button when no exercises can be found. #479

Merged
merged 4 commits into from
Jan 6, 2024
Merged

Feature - contribue exercise suggestion button when no exercises can be found. #479

merged 4 commits into from
Jan 6, 2024

Conversation

Milksheyke
Copy link
Contributor

@Milksheyke Milksheyke commented Jan 6, 2024

Description (Proposed Changes)

First time contributor. Please correct me if I'm going about any of this incorrectly.

  • Added "No matching exercises found" string to Eng and Arabic localizations.
  • Change default suggestion when no matching exercises are found to be the newly added localization line + a "Contribue an exercise" button.

Link to the issue :

Tests

Checklist

Please check that the PR fulfills all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • Set a 100 character limit in your editor/IDE to avoid white space diffs in the PR
  • Tests for the changes have been added (for bug fixes / features)
  • Added yourself to AUTHORS.md
  • Updated/added relevant documentation (doc comments with ///).
  • Added relevant reviewers.

This message is to be displayed when no exercise items are found.

Fixed typo
Created noItemsFoundBuilder callback for typeAheadFormField in exercise search form.
@rolandgeider
Copy link
Member

Looks great, thanks!

@rolandgeider rolandgeider merged commit fc97552 into wger-project:master Jan 6, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prompt users to submit an exercise when no exercises can be found
2 participants