-
-
Notifications
You must be signed in to change notification settings - Fork 568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
All modal dialogs should have "close" buttons #274
Comments
If no one else is working on this, I would like to take it on. |
Go ahead! |
I've taken a look around and here's my idea:
Is this the general idea you had in mind? I'm relatively new to Django coming from a Rails background so let me know if there is a better way of going about this. |
That would definitely be a solution. The only drawback I see is that there would be quite a bit of new templates (also, we need to pass template context to the templates, I think this is not the case by default but there's probably a flag to activate this). In an ideal world, I'd like something like this:
but I honestly don't know how difficult it would be to write such a tag in django (there is low-level API for this, but I have never used it much) and perhaps this is a bit overkill |
Thanks! I think I'll proceed with just editing the HTML to add a close button. I don't want to introduce another layer of complexity without good reason. |
This was fixed in pull request #305, closing there |
For GUI consistency, all modal dialogs in the application should have a "close" button at the bottom. It might be also be a good idea to think a bit about making this some kind of django template tag or such, but it is enough to just edit the HTML
The text was updated successfully, but these errors were encountered: