All modal dialogs should have "close" buttons

[rolandgeider]

For GUI consistency, all modal dialogs in the application should have a "close" button at the bottom. It might be also be a good idea to think a bit about making this some kind of django template tag or such, but it is enough to just edit the HTML

[jstoebel]

If no one else is working on this, I would like to take it on.

[rolandgeider]

Go ahead!

[jstoebel]

I've taken a look around and here's my idea:

• move all modals into their own template files
• create a template tag called that accepts as an argument the location of the template to render.
• render a standard modal (with close button) with the content included.

Is this the general idea you had in mind? I'm relatively new to Django coming from a Rails background so let me know if there is a better way of going about this.

[rolandgeider]

That would definitely be a solution. The only drawback I see is that there would be quite a bit of new templates (also, we need to pass template context to the templates, I think this is not the case by default but there's probably a flag to activate this).

In an ideal world, I'd like something like this:

{% modal %}
    {% title %}Foo{% endtitle %}
    {% content %}
        <p>Some HTML-content here</p>
    {% endcontent %}
{% endmodal %}

but I honestly don't know how difficult it would be to write such a tag in django (there is low-level API for this, but I have never used it much) and perhaps this is a bit overkill

[jstoebel]

Thanks! I think I'll proceed with just editing the HTML to add a close button. I don't want to introduce another layer of complexity without good reason.

[rolandgeider]

This was fixed in pull request #305, closing there