-
-
Notifications
You must be signed in to change notification settings - Fork 547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add date of birth to profile table #332
Comments
@rolandgeider Where it should be? Is it pre_save signal? |
Yeah, that would be the place |
@rolandgeider Where do you want users to enter their date of birth? |
@dtopal I'd say in the profile page and for gym administrators when adding members |
@cherya Are you planning to take on this issue or should i? |
Uh, this is actually already done, I'll close the ticket when I'm home
Am 19.10.2017 um 12:48 schrieb Ehmad Zubair:
… @cherya <https://github.com/cherya> Are you planning to take on this
issue or should i?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#332 (comment)>, or
mute the thread
<https://github.com/notifications/unsubscribe-auth/ACLNGd3Jp3p96bWipXZiBnnfarPiPMpcks5stykagaJpZM4KDPHE>.
|
@rolandgeider You forgot to close it ;) |
You forgot to close it. I spent around half an hour to add that feature. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This is mostly useful for gyms, the user's date of birth should be added to the profile table. The main problem is that there is already a field "age", which is simply an integer and is populated from the calories calculator. Users should be able to edit the exact date of birth, but should also be able to just enter the years. There should be some automatism so that if a new date is entered, the age field is automatically updated. I'm not sure what would be a correct behaviour in the opposite case, if the age in entered but contradicts the date, perhaps just ignore it? There also needs to be validation, e.g. allowing values between 10 and 99 years.
The text was updated successfully, but these errors were encountered: