Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to upload pictures of themselves #572

Closed
rolandgeider opened this issue Dec 9, 2020 · 4 comments
Closed

Allow users to upload pictures of themselves #572

rolandgeider opened this issue Dec 9, 2020 · 4 comments
Milestone

Comments

@rolandgeider
Copy link
Member

Users should be able to upload picutures to better track their progress. Along with the current date, a short (optional) description is probably useful.

Other things to consider are the security/privacy implications for this. It is probably better to let django check the logged in user and serve these files, even if it is a bit less efficient than letting the webserver do it like with all other static files.

@karmenlu
Copy link

@rolandgeider I would be interested in working on this. Does a similar feature currently exist? What does implementing this entail?

@rolandgeider
Copy link
Member Author

This would actually be really useful to have!

In a first step users should just be able to upload pictures that would be shown in a gallery. Since we have a date we can later do some other useful things such as perhaps present this information on the weight graph or such. We already allow to upload pictures for the exercises, so that part would be the same.

And for the privacy implications, giving the image a UUID as the filename would prevent people without this information from accessing it and I would say is probably secure enough (I know, I know, it wouldn't really "prevent" it, just make it highly unlikely to access it). That's why part of implementing this would be to research a bit what possibilites there are or what other people recommend using.

@karmenlu
Copy link

Ok. I can work on this one.

@rolandgeider rolandgeider added this to the 2.1 milestone Jan 10, 2021
@rolandgeider
Copy link
Member Author

Picture gallery is now available on master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants