Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache exercise responses #1033

Merged
merged 5 commits into from
May 7, 2022

Conversation

ImTheTom
Copy link
Contributor

@ImTheTom ImTheTom commented May 5, 2022

Proposed Changes

  • Overview responses for exercise, exerciseinfo and exercisebaseinfo are cached for one hour

Please check that the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Added yourself to AUTHORS.rst

@ImTheTom ImTheTom changed the title Cache exercise responses #1011 Cache exercise responses for issue #1011 May 5, 2022
@rolandgeider rolandgeider linked an issue May 6, 2022 that may be closed by this pull request
@rolandgeider
Copy link
Member

Thanks for the PR! It might be a good idea to make the TTL configurable so that this value can be reduced during development for example. We can just add it to settings_global.py to the wger_settings dict

@ImTheTom
Copy link
Contributor Author

ImTheTom commented May 6, 2022

Yeah for sure. I'll take a look at it tomorrow morning.

@rolandgeider rolandgeider changed the title Cache exercise responses for issue #1011 Cache exercise responses May 6, 2022
@ImTheTom
Copy link
Contributor Author

ImTheTom commented May 6, 2022

Also, created a MR for the docs
wger-project/docs#4

If this gets accepted.

@rolandgeider
Copy link
Member

Looks good!

@rolandgeider rolandgeider merged commit 2c926fa into wger-project:master May 7, 2022
@ImTheTom ImTheTom deleted the cache-exercise-responses branch May 7, 2022 22:05
rolandgeider added a commit that referenced this pull request May 8, 2022
rolandgeider added a commit to wger-project/docker that referenced this pull request May 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cache API responses
2 participants