Add MINIMUM_AGE_TO_TRUST variable #1188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes this is a good idea. I'm not sure right now if we mention the specific account age somewhere in the UI or just say something more general like the account needs to be of a certain age. |
|
And hooray for tests! ;) |
|
hmmm, yes it seems it's set in constants in the react project https://github.com/wger-project/react/blob/b038be369dab81782fa2b612cf40efdd7f112a12/src/utils/consts.ts#L3 Sent a PR there too. |
|
Looks good, thanks! And you even got to do a multi repo PR 😁 But now that I'm looking at it, perhaps we could name this something like |
|
Yep. I think so. Let me rename it.
…On Mon, Nov 21, 2022, 3:17 PM Roland Geider ***@***.***> wrote:
Looks good, thanks! And you even got to do a multi repo PR 😁
But now that I'm looking at it, perhaps we could name this something like
MINIMUM_ACCOUNT_AGE or better MIN_ACCOUNT_AGE_TO_TRUST?
—
Reply to this email directly, view it on GitHub
<#1188 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABTM4ZG2M5FEJKVXHSCPI2TWJNONTANCNFSM6AAAAAASFJMQRY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Done, feel free to squash commits. |
|
Merged, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1187
Proposed Changes
Please check that the PR fulfills these requirements
I'm not a Python developer, so please review carefully.