Added fedora instruction + secondary muscle #282
Conversation
| 'day_list': day_canonical_repr} | ||
|
|
||
| print(workout_canonical_form) |
|
Thanks for the PR!! You will need to update the tests, basically just adding the secondary muscles to the result. If you've got questions about this, just ask. Tests can be tedious to write but in the long run, they are really really useful. I would suggest that you separate your PRs by feature, e.g. one for the fedora packages, one for the muscles. Then things can be discussed and changed independently. |
|
Oh, and don't forget to add yourself to the AUTHORS file :) |
|
Ok I will create two new separate pull request and I didn't see there was tests until I saw them failing on travis :D I will fix them :) |
|
I mean, you can just leave this one, that was just meant as a suggestion for the future |
|
ok :P |
| 'day_list': day_canonical_repr} | ||
|
|
||
| print(workout_canonical_form) |
There was a problem hiding this comment.
You should remove this debug line
|
Hi @alokhan sorry for not answering earlier but I was on vacation and before leaving things were a bit crazy at work (I already told your friend Gary). In any case, I'm back and have taken a look at the PR, I have added two comments for small things to change, but then I can merge it :) |
|
all right no problem :) |
|
Alright, merged! |
|
hehe nice looking forward to do more like it :) |
|
👍 |
Hi,
I thought the secondary muscle on the workout overview was missing so I added them.
I also added the package list needed on fedora 23 to get it running :)
Here is my first contribution to this very nice project !