Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add style field to ExerciseImage #822

Merged
merged 1 commit into from
Sep 19, 2021

Conversation

LucasSD
Copy link
Contributor

@LucasSD LucasSD commented Sep 17, 2021

Update tests, exercises\forms.py and api\serializers.py accordingly.

Proposed Changes

  • Add style field to ExerciseImage model
  • Add style field to exercises\forms.py and api\serializers.py
  • Add style field to relevant tests
  • Create migration file
  • Check adherence to PEP8 in modified files

Please check that the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Added yourself to AUTHORS.rst

Other questions

  • Do users need to run some commands in their local instances due to this PR
    (e.g. database migration)? Yes, they need to run
    $ python manage.py migrate

Update tests, exercises\forms.py and api\serializers.py accordingly.
@rolandgeider
Copy link
Member

Thanks! I'll take a look this weekend

@LucasSD
Copy link
Contributor Author

LucasSD commented Sep 18, 2021

Thanks! I'll take a look this weekend

No problem

@rolandgeider rolandgeider linked an issue Sep 19, 2021 that may be closed by this pull request
@rolandgeider
Copy link
Member

Looks good, thanks!

@rolandgeider rolandgeider merged commit 1ff9ff2 into wger-project:master Sep 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow specifying styles for images
2 participants