Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If anyone wanted a compatibility with ROS2 Foxy version, I made a fork #57

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Chris7462
Copy link
Contributor

This isn't meant to be a PR, so sorry for making one, but I didn't find another way to notify anyone who might be interested. As you may know, the current repository is made to work with Ubuntu 18.04 and ROS Melodic, which are old and incompatible. I tried searching for one which was compatible with the latest version of ROS2 but with no luck, so I decided to make one:
https://github.com/Chris7462/floam
Hopefully somebody will find it useful.

@popfishy
Copy link

popfishy commented Dec 6, 2022

Thanks very much.

@chrissunny94
Copy link

chrissunny94 commented Nov 20, 2023

floam_bug_ceres

@Chris7462 , is there a bug in the latter version Ceres solver . Because it crashes while turning .

Kindly test it with Kitti dataset , it goes haywire just after the first turn .

@Chris7462
Copy link
Contributor Author

Chris7462 commented Nov 20, 2023

@Chris7462 , is there a bug in the latter version Ceres solver . Because it crashes while turning .

Kindly test it with Kitti dataset , it goes haywire just after the first turn .

@chrissunny94, Yes, I am aware of this issue, and I believe it originates from the Ceres solver itself. To test this hypothesis, I created the g2o branch, changed the Ceres solver to g2o without modifying the cost function and jacobian, and observed that the problem disappeared.

As of now, the root cause remains unknown. Any insights you may have regarding this issue is welcome.

@chrissunny94
Copy link

chrissunny94 commented Nov 20, 2023

@Chris7462 , is there a bug in the latter version Ceres solver . Because it crashes while turning .
Kindly test it with Kitti dataset , it goes haywire just after the first turn .

@chrissunny94, Yes, I am aware of this issue, and I believe it originates from the Ceres solver itself. To test this hypothesis, I created the g2o branch, changed the Ceres solver to g2o without modifying the cost function and jacobian, and observed that the problem disappeared.

As of now, the root cause remains unknown. Any insights you may have regarding this issue is welcome.

So nice of you , let me try .

But will be on a look out for a solution via Ceres as well !

Tried it , works with ROS2 Foxy !

But has some issue with ROS2 humble .
tracking in the following following ticket .
RainerKuemmerle/g2o#742

@Chris7462
Copy link
Contributor Author

@Chris7462 , is there a bug in the latter version Ceres solver . Because it crashes while turning .
Kindly test it with Kitti dataset , it goes haywire just after the first turn .

@chrissunny94, Yes, I am aware of this issue, and I believe it originates from the Ceres solver itself. To test this hypothesis, I created the g2o branch, changed the Ceres solver to g2o without modifying the cost function and jacobian, and observed that the problem disappeared.
As of now, the root cause remains unknown. Any insights you may have regarding this issue is welcome.

So nice of you , let me try .

But will be on a look out for a solution via Ceres as well !

Tried it , works with ROS2 Foxy !

But has some issue with ROS2 humble . tracking in the following following ticket . RainerKuemmerle/g2o#742

I'm not sure how you installed g2o, but I've tested my g2o branch on both Foxy and Humble, and it worked without any issues.
Note that I don't have ros-<distro>-libg2o installed, but I have installed the g2o in the system.

@chrissunny94
Copy link

@Chris7462 , is there a bug in the latter version Ceres solver . Because it crashes while turning .
Kindly test it with Kitti dataset , it goes haywire just after the first turn .

@chrissunny94, Yes, I am aware of this issue, and I believe it originates from the Ceres solver itself. To test this hypothesis, I created the g2o branch, changed the Ceres solver to g2o without modifying the cost function and jacobian, and observed that the problem disappeared.
As of now, the root cause remains unknown. Any insights you may have regarding this issue is welcome.

So nice of you , let me try .
But will be on a look out for a solution via Ceres as well !
Tried it , works with ROS2 Foxy !
But has some issue with ROS2 humble . tracking in the following following ticket . RainerKuemmerle/g2o#742

I'm not sure how you installed g2o, but I've tested my g2o branch on both Foxy and Humble, and it worked without any issues. Note that I don't have ros--libg2o installed, but I have installed the g2o in the system.

Yes agree , it works with g2o installed on the system .

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants