Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

edit install notes (add npm) #13

Merged
merged 1 commit into from Apr 20, 2016
Merged

edit install notes (add npm) #13

merged 1 commit into from Apr 20, 2016

Conversation

sunstorymvp
Copy link
Contributor

@whackashoe whackashoe merged commit 8908cff into whackashoe:master Apr 20, 2016
@whackashoe
Copy link
Owner

Thanks a bunch!

@whackashoe
Copy link
Owner

This might make more sense to point npm here rather than your repo, as otherwise any fixes or updates wont be propagated automatically

@sunstorymvp
Copy link
Contributor Author

sunstorymvp commented Apr 20, 2016

Yes, this is reasonable.

But there is some stuff that needs to be done:

First one, npm package needs to be exported like this:
https://github.com/sunstorymvp/antimoderate/blob/master/antimoderate.js#L279-L281

After that AntiModerate is no longer global, but it can be imported or required. I don't know how it will affect the usage through the bower... if there is no problem with it i can do PR for you. Maybe @amoludage could tell something?

Second is package.json file.
https://github.com/sunstorymvp/antimoderate/blob/master/package.json

@sunstorymvp sunstorymvp deleted the patch-1 branch April 20, 2016 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants