Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple Fixes #6

Closed

Conversation

Lisias
Copy link

@Lisias Lisias commented Oct 25, 2020

  • Restoring Equip/Remove helmet to EVA capable Tourists
  • Preventing regular Crew to be "promoted" to Tourists at all
  • Surviving KSP's UpdatePipeline
    • Restoring Tourists Configuration between loading savegames
  • Applying Tourists rules to Tourists sitting on External Command Seats

…ill always behave nicely (they are on duty!)
@Lisias Lisias marked this pull request as draft October 25, 2020 22:30
@Lisias
Copy link
Author

Lisias commented Oct 25, 2020

I had to convert it to a draft. Something regressed on my rig, probably a NRE that I prevented on the OnLoad handler but by then, that code stopped being ran at all and the reinit thingy regressed.

@Lisias
Copy link
Author

Lisias commented Oct 26, 2020

False alarme! I had forgotten a rogue DLL on the installment! :)

On the bright side, I remembered that once Tourists can be toured on External Command Seats, it would be nice to allow them to take selfies from it.

Jebediah Kerman-Kerbin-20-10-25-21:55:34

screenshot58

And, of course, selfies still works - and without helmets!

Wehrtop Kerman-Kerbin-20-10-25-21:57:08

So I'm promoting this PR to be applied again.

@Lisias Lisias marked this pull request as ready for review October 26, 2020 01:19
@Lisias Lisias closed this Jul 25, 2022
@Lisias Lisias deleted the pullrequests/to/upstream/2020-1025 branch July 25, 2022 03:52
@Lisias Lisias restored the pullrequests/to/upstream/2020-1025 branch August 24, 2022 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant