Add support for multiple search repositories #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjamet
force-pushed
the
tap/multi-repo
branch
from
00205b6
to
e5e6a6f
Compare
Codecov Report
@@ Coverage Diff @@
## master #108 +/- ##
==========================================
- Coverage 47.73% 45.04% -2.69%
==========================================
Files 15 15
Lines 794 717 -77
==========================================
- Hits 379 323 -56
+ Misses 386 365 -21
Partials 29 29
Continue to review full report at Codecov.
|
tjamet
force-pushed
the
tap/multi-repo
branch
from
e5e6a6f
to
9ae0e4e
Compare
Up until now, whalebrew restricts its searches to https://hub.docker.com/u/whalebrew This commit introduces the ability to customize search organization under docker hub. To customize it, place a file like ``` registries: - dockerHub: owner: whalebrew ``` You can add as many search repositories as desired, all of them will be searched. Currently, there is no authentication to the search repositories. Only public images will be retrieved. A step forward for whaleebrew tap discussed in #102
tjamet
force-pushed
the
tap/multi-repo
branch
from
9ae0e4e
to
ead2fdc
Compare
tjamet
force-pushed
the
tap/multi-repo
branch
from
aad0720
to
7200c61
Compare
tjamet
added a commit
that referenced
this pull request
Oct 26, 2020
Refactor how search is actually working to allow hooking and injecting several search methods. The alternative search method is using the registry [catalog](https://docs.docker.com/registry/spec/api/#catalog) listing all images in the registry and filtering them according to the searched term. Though this method is particularly inefficient with large registries. We should at some point implement some kind of cache to speed up consequent searches and avoid over-loading the remote server. Similarly, to improve performances, we should probably think of a way to integrate directly with the registries APIs so we can get better performances. Finally, this method can not be used on docker hub, that still uses the dedicated docker hub search method, as the catalog has been [disabled on docker hub](https://stackoverflow.com/a/37518393) because it would list all the images available on docker hub fixes: #108
tjamet
added a commit
that referenced
this pull request
Oct 26, 2020
Refactor how search is actually working to allow hooking and injecting several search methods. The alternative search method is using the registry [catalog](https://docs.docker.com/registry/spec/api/#catalog) listing all images in the registry and filtering them according to the searched term. Though this method is particularly inefficient with large registries. We should at some point implement some kind of cache to speed up consequent searches and avoid over-loading the remote server. Similarly, to improve performances, we should probably think of a way to integrate directly with the registries APIs so we can get better performances. Finally, this method can not be used on docker hub, that still uses the dedicated docker hub search method, as the catalog has been [disabled on docker hub](https://stackoverflow.com/a/37518393) because it would list all the images available on docker hub fixes: #108
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Up until now, whalebrew restricts its searches to https://hub.docker.com/u/whalebrew
This commit introduces the ability to customize search organization under docker hub.
To customize it, place a file like
You can add as many search repositories as desired, all of them will be searched.
Currently, there is no authentication to the search repositories. Only public images will be retrieved.
A step forward for whaleebrew tap discussed in #102