Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3 compatibility #2

Open
whaleygeek opened this issue Jul 26, 2017 · 4 comments
Open

Python 3 compatibility #2

whaleygeek opened this issue Jul 26, 2017 · 4 comments

Comments

@whaleygeek
Copy link
Owner

It isn't

@whaleygeek
Copy link
Owner Author

Need to pull over the portscan and pyserial module from https://github.com/whaleygeek/bitio and then this will be Python 3 compatible.

@whaleygeek
Copy link
Owner Author

Wait for the bitio portscan module to be changed in bitio to change the name of the portscan.cache to that of the device name first, then that will also allow bitio and punchcard_reader to run concurrently in the same Python program.

@whaleygeek
Copy link
Owner Author

Had a quick look at this. Remember that Python3 imports work differently. I did a quick test...

delete portscan.py
copy portscan folder and serial folder from bitio project into this folder
run it up with python3

  File "card2csv.py", line 17, in <module>
    import cardreader
  File "/Users/davidw/tmp/punchcard_reader/cardreader/__init__.py", line 5, in <module>
    from arduino import *
ModuleNotFoundError: No module named 'arduino'

I suspect this is because of the differences in how package imports work between Python2 and Python3, probably all the package based imports need re-coding as well, so this is not a quick fix, and needs to be done and tested properly.

cc @GemmaMayLatham

@whaleygeek
Copy link
Owner Author

Gemma reported that this quick fix worked for her, must be a python version/platform thing I guess. Will have to do this properly later and re test it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant