This repository has been archived by the owner on Jul 25, 2022. It is now read-only.
Do not set environment variables in tests #2008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have a number of intermittently failing tests that are due to setting environment variables within the tests.
Rust tests run in parallel and the environment is basically a singleton. Therefore, these tests leak state with each other and are non-deterministic.
In addition, we are pulling items between action plugins, where we could factor it out into the env instead.
Fixes #1826.
Signed-off-by: Joe Grund <jgrund@whamcloud.io>
ip1981
reviewed
Jun 23, 2020
ip1981
reviewed
Jun 23, 2020
| @@ -125,7 +126,9 @@ mod lpurge_conf_tests { | |||
| freelo: 60, | |||
| mailbox: "foobar".to_string(), | |||
| }; | |||
| let file = conf_name(&cfg).await.expect("name could not be created"); | |||
| let file = conf_name(&cfg, "/etc/lpurge/{fs}/{ost}-{pool}.conf") | |||
ip1981
reviewed
Jun 23, 2020
| write!( | ||
| f, | ||
| impl Config { | ||
| fn generate_unit(&self, socket: String) -> String { |
There was a problem hiding this comment.
I think this could be unified with expand_path_fmt: we just format strings, file name of content.
There was a problem hiding this comment.
Can you expand on how the unification would work? One item is generating a systemd unit the other is generating a path with optional values.
Are you suggesting to use strfmt for both fns?
There was a problem hiding this comment.
Yes, strfmt for both. Even maybe in one pass, like cfg.write(socket, file_name_template);
|
There are some unused imports. |
Signed-off-by: Joe Grund <jgrund@whamcloud.io>
ip1981
approved these changes
Jun 24, 2020
nlinker
approved these changes
Jun 24, 2020
jgrund
added a commit
that referenced
this pull request
Jun 25, 2020
* Do not set environment variables in tests
We have a number of intermittently failing tests that are due to setting environment variables within the tests.
Rust tests run in parallel and the environment is basically a singleton. Therefore, these tests leak state with each other and are non-deterministic.
In addition, we are pulling items between action plugins, where we could factor it out into the env instead.
Fixes #1826.
Signed-off-by: Joe Grund <jgrund@whamcloud.io>
* Remove unused imports
Signed-off-by: Joe Grund <jgrund@whamcloud.io>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a number of intermittently failing tests that are due to setting environment variables within the tests.
Rust tests run in parallel and the environment is basically a singleton. Therefore, these tests leak state with each other and are non-deterministic.
In addition, we are pulling items between action plugins, where we could factor it out into the env instead.
Fixes #1826.
Signed-off-by: Joe Grund jgrund@whamcloud.io
This change is