Handle sessions in one place #2026
Conversation
ip1981
force-pushed
the
ip1981/1805-logout
branch
from
5417f37
to
e137465
Compare
ip1981
force-pushed
the
ip1981/1805-logout
branch
from
e137465
to
5a0ede5
Compare
| orders.perform_g_cmd( | ||
| fetch_session() | ||
| .method(fetch::Method::Delete) | ||
| .fetch(|_| GMsg::AuthProxy(Box::new(Msg::LoggedIn))), |
There was a problem hiding this comment.
A samurai without a sword is like a samurai with one, but only without one. -- Re #1805
This includes logging in and logging out. `logged_out` is removed because "disabled" is not working with `a` anyway. Can be added to the auth::Model if needed. Signed-off-by: Igor Pashev <pashev.igor@gmail.com>
ip1981
force-pushed
the
ip1981/1805-logout
branch
from
5a0ede5
to
04af863
Compare
There was a problem hiding this comment.
Reviewed 6 of 7 files at r1, 1 of 1 files at r3.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @ip1981)
iml-gui/crate/src/auth.rs, line 33 at r3 (raw file):
Fetched(fetch::FetchObject<Session>), Logout, LoggedIn,
Just Login to be symmetric with Logout?
They are different: Logout is a command, LoggedIn is a result. Similar to Fetch and Fetched. |
|
There might be an minor issue when anonymous access is not allowed, but easy to fix if any. |
This happens without this patch: https://github.com/whamcloud/integrated-manager-for-lustre/issues/2030. Also fixed by this PR :) |
| model.cancel = None; | ||
|
|
||
| let request = fetch_session().controller(|controller| model.request_controller = Some(controller)); | ||
|
|
||
| orders.skip().perform_cmd(request.fetch_json(Msg::Fetched)); | ||
| } | ||
| Msg::SetSession(session) => { |
There was a problem hiding this comment.
I think this and this was the cause of #2030.
This includes logging in and logging out.
logged_outis removed because "disabled" is not working withaanyway.Can be added to the auth::Model if needed.
Closes #2030, #1805, #1737, #1735 (supersedes #1755).
This change is