Skip to content
This repository has been archived by the owner on Jul 25, 2022. It is now read-only.

Fix agent ostpool resend #2037

Merged
merged 5 commits into from
Jul 8, 2020
Merged

Fix agent ostpool resend #2037

merged 5 commits into from
Jul 8, 2020

Conversation

utopiabound
Copy link
Contributor

@utopiabound utopiabound commented Jul 1, 2020 •
edited by jgrund
Loading

Resend every 5 minutes.

Signed-off-by: Nathaniel Clark nclark@whamcloud.com

This change is Reviewable

@utopiabound
Fix agent ostpool resend
5c602fc 
Resend every 5 minutes.

Signed-off-by: Nathaniel Clark <nclark@whamcloud.com>
@utopiabound utopiabound added the bug label Jul 1, 2020
@utopiabound utopiabound added this to the IML EX V3 milestone Jul 1, 2020
@utopiabound utopiabound requested review from jgrund and a team July 1, 2020 20:15
@utopiabound utopiabound self-assigned this Jul 1, 2020
jgrund
jgrund suggested changes Jul 1, 2020
View reviewed changes
Copy link
Member

@jgrund jgrund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Set the duration outside the trait instead of assigning it each loop.

iml-agent/src/daemon_plugins/ostpool.rs Outdated Show resolved Hide resolved
@utopiabound
Use Duration as const
fae4180 
Signed-off-by: Nathaniel Clark <nclark@whamcloud.com>
@utopiabound utopiabound requested a review from jgrund July 2, 2020 17:47
ip1981
ip1981 previously approved these changes Jul 2, 2020
View reviewed changes
@jgrund
Copy link
Member

jgrund commented Jul 2, 2020

can you update cargo fmt?

@jgrund jgrund self-requested a review July 2, 2020 19:25
jgrund
jgrund suggested changes Jul 2, 2020
View reviewed changes
Copy link
Member

@jgrund jgrund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cargo fmt needs fixing.

@utopiabound
Cargo fmt
e1b0682 
Signed-off-by: Nathaniel Clark <nclark@whamcloud.com>
@utopiabound utopiabound requested review from jgrund and ip1981 July 2, 2020 19:34
@jgrund jgrund merged commit 886262d into master Jul 8, 2020
@jgrund jgrund deleted the ostpool-resend branch July 8, 2020 00:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ip1981 ip1981 ip1981 approved these changes

@jgrund jgrund jgrund approved these changes

Assignees

@utopiabound utopiabound

Labels
bug
Projects
None yet
Milestone
IML EX V3
3 participants
@utopiabound @jgrund @ip1981