-
Notifications
You must be signed in to change notification settings - Fork 35
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ip1981)
iml-manager-cli/src/server.rs, line 544 at r1 (raw file):
pub async fn server_cli(command: Option<ServerCommand>) -> Result<(), ImlManagerCliError> { match command { None => list_server(DisplayType::Tabular).await?,
As an alternative: pull ServerCommand
out of Option
and match on it separately, break early if it's None
. Avoids duplicated Some
on all branches.
481fdc5
to
3f49234
Compare
Updated. Thanks! |
That is: iml server [list] Signed-off-by: Igor Pashev <pashev.igor@gmail.com>
3f49234
to
e8b1093
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @ip1981)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In principle there are examples of such behaviour in the syntax command noun
in e.g. git
where git branch
shows the current branch, git tag
shows the list of tags.
Seems to be logical.
That is: iml server [list] Signed-off-by: Igor Pashev <pashev.igor@gmail.com>
Closes #2041.
Signed-off-by: Igor Pashev pashev.igor@gmail.com
This change is![Reviewable](https://camo.githubusercontent.com/23b05f5fb48215c989e92cc44cf6512512d083132bd3daf689867c8d9d386888/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)