Skip to content
This repository has been archived by the owner on Jul 25, 2022. It is now read-only.

Add alternate client mount provisioners #2094

Merged
merged 4 commits into from
Jul 24, 2020
Merged

Add alternate client mount provisioners #2094

merged 4 commits into from
Jul 24, 2020

Conversation

utopiabound
Copy link
Contributor

@utopiabound utopiabound commented Jul 20, 2020

Fixes Issue #2093

Signed-off-by: Nathaniel Clark nclark@whamcloud.com


This change is Reviewable

Fixes Issue #2093

Signed-off-by: Nathaniel Clark <nclark@whamcloud.com>
@utopiabound utopiabound requested a review from a team July 20, 2020 20:57
@utopiabound utopiabound self-assigned this Jul 20, 2020
ip1981
ip1981 previously approved these changes Jul 21, 2020
johnsonw
johnsonw previously approved these changes Jul 21, 2020
Copy link
Contributor

@johnsonw johnsonw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@jgrund
Copy link
Member

jgrund commented Jul 21, 2020

In #2093 the provisioner will succeed regardless if the command failed.

Can you add set -e to:

Signed-off-by: Nathaniel Clark <nclark@whamcloud.com>
@utopiabound utopiabound dismissed stale reviews from johnsonw and ip1981 via 313a5b3 July 21, 2020 18:04
@jgrund jgrund merged commit a6b1488 into master Jul 24, 2020
@jgrund jgrund deleted the vagrant-clients branch July 24, 2020 16:53
beevans pushed a commit to beevans/integrated-manager-for-lustre that referenced this pull request Aug 6, 2020
* Add alternate client mount provisioners

Fixes Issue #2093

Signed-off-by: Nathaniel Clark <nclark@whamcloud.com>

* Fail provision if mount fails

Signed-off-by: Nathaniel Clark <nclark@whamcloud.com>

Co-authored-by: Joe Grund <jgrund@whamcloud.io>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants