This repository has been archived by the owner on Jul 25, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 35
Add alternate client mount provisioners #2094
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes Issue #2093 Signed-off-by: Nathaniel Clark <nclark@whamcloud.com>
ip1981
previously approved these changes
Jul 21, 2020
johnsonw
previously approved these changes
Jul 21, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 👍
In #2093 the provisioner will succeed regardless if the command failed. Can you add
|
Signed-off-by: Nathaniel Clark <nclark@whamcloud.com>
johnsonw
approved these changes
Jul 21, 2020
ip1981
approved these changes
Jul 21, 2020
ip1981
approved these changes
Jul 24, 2020
beevans
pushed a commit
to beevans/integrated-manager-for-lustre
that referenced
this pull request
Aug 6, 2020
* Add alternate client mount provisioners Fixes Issue #2093 Signed-off-by: Nathaniel Clark <nclark@whamcloud.com> * Fail provision if mount fails Signed-off-by: Nathaniel Clark <nclark@whamcloud.com> Co-authored-by: Joe Grund <jgrund@whamcloud.io>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue #2093
Signed-off-by: Nathaniel Clark nclark@whamcloud.com
This change is![Reviewable](https://camo.githubusercontent.com/23b05f5fb48215c989e92cc44cf6512512d083132bd3daf689867c8d9d386888/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)