This repository has been archived by the owner on Jul 25, 2022. It is now read-only.
Show command modal when modifying file scan #2095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Igor Pashev <pashev.igor@gmail.com>
ip1981
commented
Jul 21, 2020
| Ok(_) => { | ||
| orders.skip(); | ||
| Ok(x) => { | ||
| let x = command_modal::Input::Commands(vec![Arc::new(x.data.command)]); |
There was a problem hiding this comment.
This could be unified with other command_model consumers by using fetch_json_data, but might need significant refactoring.
There was a problem hiding this comment.
Not worth it yet. There is a large seed 0.7 refactor looming, which redoes the fetch layer.
ip1981
commented
Jul 21, 2020
| @@ -31,7 +31,7 @@ def dehydrate_locked_item_content_type_id(self, bundle): | |||
| if hasattr(locked_item, "content_type"): | |||
| return locked_item.content_type.id | |||
| else: | |||
| return ContentType.objects.get_for_model(locked_item) | |||
| return ContentType.objects.get_for_model(locked_item).id | |||
There was a problem hiding this comment.
Interesting we haven't hit this before, this code has not been changed in 8 years :)
nlinker
approved these changes
Jul 21, 2020
johnsonw
approved these changes
Jul 21, 2020
beevans
pushed a commit
to beevans/integrated-manager-for-lustre
that referenced
this pull request
Aug 6, 2020
Signed-off-by: Igor Pashev <pashev.igor@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1762, #2090.
Signed-off-by: Igor Pashev pashev.igor@gmail.com
This change is