tests: Mount filesystem(s) during detect_fs

[utopiabound]

vagrant: Split mount from create for zfs backed fs
test: Check that the correct number of filesystems
were detected in detect_fs()

Signed-off-by: Nathaniel Clark nclark@whamcloud.com

---

This change is 

[johnsonw]

Just curious, could it also be:

serde_json::from_slice(&o.stdout)l.unwrap::<Vec<serde_json::Value>>()

?

[utopiabound]

I tried cajoling that line to do that, but I couldn't figure it out:

error[E0107]: wrong number of type arguments: expected 0, found 1
   --> iml-system-test-utils/src/ssh.rs:279:61
    |
279 |         .map(|o| serde_json::from_slice(&o.stdout).unwrap::<Vec<serde_json::Value>>())
    |                                                             ^^^^^^^^^^^^^^^^^^^^^^ unexpected type argument

error: aborting due to previous error

[jgrund]

The reason that doesn't work is unwrap has no generic parameter to fill in.

The turbofish needs to be on from_slice which does have a generic parameter:

https://docs.serde.rs/serde_json/fn.from_slice.html

[jgrund]

Suggested change

	.map(|o| {
	let v: Vec<serde_json::Value> = serde_json::from_slice(&o.stdout).unwrap();
	v
	})
	.map(|o| serde_json::from_slice::<Vec<serde_json::Value>>(&o.stdout).unwrap())

[mkpankov]

👍

Reviewed 3 of 6 files at r1, 2 of 4 files at r2, 9 of 9 files at r3, 2 of 2 files at r4.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @johnsonw and @utopiabound)

[utopiabound]

Reviewed 3 of 6 files at r1, 2 of 4 files at r2, 9 of 9 files at r3, 2 of 2 files at r4, 3 of 3 files at r5.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @johnsonw and @utopiabound)

[utopiabound]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @jgrund and @johnsonw)

---

iml-system-test-utils/src/ssh.rs, line 277 at r1 (raw file):

Previously, jgrund (Joe Grund) wrote…

The reason that doesn't work is unwrap has no generic parameter to fill in.

The turbofish needs to be on from_slice which does have a generic parameter:

https://docs.serde.rs/serde_json/fn.from_slice.html

Done.

---

iml-system-test-utils/src/ssh.rs, line 279 at r1 (raw file):

Previously, jgrund (Joe Grund) wrote…

        .map(|o| serde_json::from_slice::<Vec<serde_json::Value>>(&o.stdout).unwrap())

Done.

[mkpankov]

Reviewed 3 of 3 files at r5.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @jgrund and @johnsonw)