Skip to content
This repository has been archived by the owner on Jul 25, 2022. It is now read-only.

Rename try_mount to mount in iml-agent #2104

Merged
merged 3 commits into from
Jul 27, 2020
Merged

Rename try_mount to mount in iml-agent #2104

merged 3 commits into from
Jul 27, 2020

Conversation

ip1981
Copy link
Member

@ip1981 ip1981 commented Jul 24, 2020 •
edited
Loading 

# /usr/bin/iml-agent mount --help
iml-agent-mount 0.3.0
Mount lustre device

USAGE:
    iml-agent mount <lustre-device> <mount-point>

FLAGS:
    -h, --help       Prints help information
    -V, --version    Prints version information

ARGS:
    <lustre-device>    For example, 10.73.20.11@tcp0:10.73.20.12@tcp0:/fs2
    <mount-point>      For example, /mnt/fs2

Signed-off-by: Igor Pashev pashev.igor@gmail.com

This change is Reviewable

@ip1981
Deduplicate lctl calls in iml-agent
4116de7 
Signed-off-by: Igor Pashev <pashev.igor@gmail.com>
@ip1981
Rename try_mount to mount in iml-agent
3926830 
Signed-off-by: Igor Pashev <pashev.igor@gmail.com>
@ip1981 ip1981 requested a review from a team July 24, 2020 11:45
@ip1981 ip1981 self-assigned this Jul 24, 2020
nlinker
nlinker previously approved these changes Jul 24, 2020
View reviewed changes
Base automatically changed from ip1981/agent-lctl to master July 24, 2020 17:44
@jgrund jgrund dismissed nlinker’s stale review July 24, 2020 17:44

The base branch was changed.

@jgrund jgrund requested review from nlinker and jgrund July 24, 2020 17:45
jgrund
jgrund approved these changes Jul 24, 2020
View reviewed changes
Copy link
Member

@jgrund jgrund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending tests pass

@ip1981 ip1981 closed this Jul 27, 2020
@ip1981 ip1981 reopened this Jul 27, 2020
@jgrund
Copy link
Member

jgrund commented Jul 27, 2020

Pass in https://build.whamcloud.com/job/manager-for-lustre/1433/

@jgrund jgrund merged commit 631500c into master Jul 27, 2020
@jgrund jgrund deleted the ip1981/iml-agent-mount branch July 27, 2020 12:26
beevans pushed a commit to beevans/integrated-manager-for-lustre that referenced this pull request Aug 6, 2020
@ip1981 @jgrund @beevans
Rename try_mount to mount in iml-agent (whamcloud#2104)
24f2b07 
* Deduplicate lctl calls in iml-agent

Signed-off-by: Igor Pashev <pashev.igor@gmail.com>

* Rename try_mount to mount in iml-agent

Signed-off-by: Igor Pashev <pashev.igor@gmail.com>

Co-authored-by: Joe Grund <jgrund@whamcloud.io>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jgrund jgrund jgrund approved these changes

@nlinker nlinker nlinker approved these changes

Assignees

@ip1981 ip1981

Labels
enhancement
Projects
None yet
Milestone
No milestone
3 participants
@ip1981 @jgrund @nlinker