This repository has been archived by the owner on Jul 25, 2022. It is now read-only.
Build up targets from device-scanner output #2107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnsonw
force-pushed
the
build-targets
branch
3 times, most recently
from
0c0a194
to
5a51b90
Compare
|
This video highlights the following details:
|
johnsonw
force-pushed
the
build-targets
branch
2 times, most recently
from
dde0ff1
to
4fb1f70
Compare
johnsonw
force-pushed
the
build-targets
branch
2 times, most recently
from
b3b7fcb
to
8cce169
Compare
|
Latest tests running here: https://build.whamcloud.com/job/manager-for-lustre/1657/ |
johnsonw
force-pushed
the
build-targets
branch
2 times, most recently
from
e730f9c
to
a540cc6
Compare
ip1981
previously approved these changes
Aug 12, 2020
johnsonw
force-pushed
the
build-targets
branch
from
a540cc6
to
f6a8f1f
Compare
jgrund
commented
Aug 18, 2020
johnsonw
force-pushed
the
build-targets
branch
2 times, most recently
from
a6c6b76
to
0e2ab3e
Compare
jgrund
force-pushed
the
build-targets
branch
2 times, most recently
from
73a2ad9
to
5a335cd
Compare
jgrund
commented
Aug 19, 2020
There was a problem hiding this comment.
I think the API wrapping collections would be cleaner if they were implemented as traits or free fns instead.
When you wrap a collection, you need to write methods for everything the collection that you want to expose or otherwise reach inside the wrapper to use it.
johnsonw
force-pushed
the
build-targets
branch
from
4fdabba
to
01a2dcb
Compare
johnsonw
previously approved these changes
Aug 20, 2020
The device-scanner has all the needed info to determine targets at runtime. This patch finds those targets and figures out all the hosts they can be mounted on. We can then persist that info to the database and use it instead of having to detect manually. Signed-off-by: Joe Grund <jgrund@whamcloud.io> Signed-off-by: johnsonw <wjohnson@whamcloud.com>
Signed-off-by: johnsonw <wjohnson@whamcloud.com>
Signed-off-by: johnsonw <wjohnson@whamcloud.com>
Signed-off-by: johnsonw <wjohnson@whamcloud.com>
Signed-off-by: Joe Grund <jgrund@whamcloud.io>
johnsonw
force-pushed
the
build-targets
branch
from
f9dc971
to
04b88c2
Compare
Signed-off-by: johnsonw <wjohnson@whamcloud.com>
johnsonw
approved these changes
Aug 20, 2020
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The device-scanner has all the needed info to determine targets at
runtime.
This patch finds those targets and figures out all the hosts they can be
mounted on. We can then persist that info to the database and use it
instead of having to detect manually.
Signed-off-by: Joe Grund jgrund@whamcloud.io
This change is