This repository has been archived by the owner on Jul 25, 2022. It is now read-only.
Implement mounting and unmounting snapshots #2109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ip1981
reviewed
Jul 28, 2020
| (filesystem_name, snapshot_name): (String, String), | ||
| ) -> Result<(), ImlAgentError> { | ||
| let args = &[ | ||
| "snapshot_umount", |
There was a problem hiding this comment.
I wonder if we should stick to the lctl naming (umount/unmount) :)
There was a problem hiding this comment.
I don't want these Unixy 1-letter contractions in our code to be honest
jgrund
previously approved these changes
Jul 28, 2020
johnsonw
previously approved these changes
Jul 28, 2020
ip1981
previously approved these changes
Jul 28, 2020
ip1981
force-pushed
the
ip1981/ex-1468-snapshots
branch
2 times, most recently
from
2ef3f43
to
87cf2be
Compare
jgrund
dismissed stale reviews from ip1981, johnsonw, and themself
The base branch was changed.
|
This patch has conflicts with master |
Signed-off-by: Michael Pankov <work@michaelpankov.com>
Signed-off-by: Michael Pankov <work@michaelpankov.com>
Signed-off-by: Michael Pankov <work@michaelpankov.com>
Signed-off-by: Michael Pankov <work@michaelpankov.com>
Signed-off-by: Michael Pankov <work@michaelpankov.com>
Signed-off-by: Michael Pankov <work@michaelpankov.com>
Signed-off-by: Michael Pankov <work@michaelpankov.com>
ip1981
approved these changes
Jul 30, 2020
johnsonw
approved these changes
Jul 30, 2020
ip1981
reviewed
Jul 30, 2020
| #[derive(serde::Deserialize, Debug)] | ||
| #[cfg_attr(feature = "cli", derive(StructOpt))] | ||
| /// Ask agent to unmount the snapshot | ||
| pub struct Unmount { |
There was a problem hiding this comment.
Btw, I was already thinking that simple tuple was good :) At least the same structure could be used for both mounting and unmounting.
There was a problem hiding this comment.
Tuple is good, but would need to be a tuple struct. The value here is being able to have the caller break at compile time if this changes.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Michael Pankov work@michaelpankov.com
This change is