Skip to content
This repository has been archived by the owner on Jul 25, 2022. It is now read-only.

Implement Mount Step #2121

Merged
merged 13 commits into from
Aug 6, 2020
Merged

Implement Mount Step #2121

merged 13 commits into from
Aug 6, 2020

Conversation

mkpankov
Copy link
Contributor

@mkpankov mkpankov commented Jul 31, 2020 •
edited by jgrund
Loading

Signed-off-by: Michael Pankov work@michaelpankov.com

This change is Reviewable

@mkpankov mkpankov marked this pull request as draft July 31, 2020 11:03
@mkpankov mkpankov force-pushed the mount-step branch 2 times, most recently from e2283d2 to ce7ec22 Compare August 3, 2020 13:12
@mkpankov mkpankov self-assigned this Aug 3, 2020
@mkpankov mkpankov marked this pull request as ready for review August 3, 2020 13:13
@mkpankov mkpankov requested review from jgrund and a team August 3, 2020 13:14
@mkpankov mkpankov added this to the IML EX V3 milestone Aug 3, 2020
@mkpankov
Refactor to a match
8791a90 
Signed-off-by: Michael Pankov <work@michaelpankov.com>
@mkpankov
[WIP]
fff4197 
Signed-off-by: Michael Pankov <work@michaelpankov.com>
@mkpankov
Rename
7d0856c 
Signed-off-by: Michael Pankov <work@michaelpankov.com>
@mkpankov
[WIP]
133275c 
Signed-off-by: Michael Pankov <work@michaelpankov.com>
@mkpankov
[WIP]
c120dd7 
Signed-off-by: Michael Pankov <work@michaelpankov.com>
@mkpankov
Implement invoke_rust_agent
bd553bc 
Signed-off-by: Michael Pankov <work@michaelpankov.com>
@mkpankov
Make it compile
86e28d8 
Signed-off-by: Michael Pankov <work@michaelpankov.com>
@mkpankov
Support snapshot_unmount as well
e0d548e 
Signed-off-by: Michael Pankov <work@michaelpankov.com>
@mkpankov
Fix unmount naming
703b067 
Signed-off-by: Michael Pankov <work@michaelpankov.com>
@mkpankov
Reuse type alias
159a09b 
Signed-off-by: Michael Pankov <work@michaelpankov.com>
@mkpankov
Make it store the abort handle
b42171d 
Signed-off-by: Michael Pankov <work@michaelpankov.com>
@mkpankov mkpankov requested review from ip1981 and jgrund August 5, 2020 12:44
jgrund
jgrund reviewed Aug 5, 2020
View reviewed changes
Copy link
Member

@jgrund jgrund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since these actions don't actually do anything locally, they can just use invoke_rust_action_expect_result.

I was anticipating there would be some db work needed for these, but we can just defer that for now until we reach the job level.

@mkpankov
Revert most of code to master
9ea1a0e 
Signed-off-by: Michael Pankov <work@michaelpankov.com>
@mkpankov
Fix typo
eb0b318 
Signed-off-by: Michael Pankov <work@michaelpankov.com>
@mkpankov mkpankov requested a review from jgrund August 6, 2020 07:41
@jgrund jgrund merged commit 5c4e337 into master Aug 6, 2020
@jgrund jgrund deleted the mount-step branch August 6, 2020 13:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jgrund jgrund jgrund approved these changes

@nlinker nlinker nlinker approved these changes

@ip1981 ip1981 ip1981 approved these changes

Assignees

@mkpankov mkpankov

Labels
enhancement
Projects
None yet
Milestone
IML EX V3
4 participants
@mkpankov @ip1981 @jgrund @nlinker