This repository has been archived by the owner on Jul 25, 2022. It is now read-only.
Extract remote_action code from sender #2123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkpankov
previously approved these changes
Aug 3, 2020
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @jgrund)
iml-services/iml-action-runner/src/remote_action.rs, line 76 at r1 (raw file):
let ch = iml_rabbit::create_channel(&conn).await?; drop(conn);
Why do we do this?
Currently, the only way to run a `remote_action` is to call it through the `action-runner`. This means even if there is code within the `action-runner` that wants to call a local action it will need to schedule it via HTTP / UDS. As a first step to making this more efficient, move the `remote_action` code out to a directly callable fn. Signed-off-by: Joe Grund <jgrund@whamcloud.io>
jgrund
force-pushed
the
extract_remote_action
branch
from
480f4cf
to
e4f09a3
Compare
Connections are closed when there are no more handles to them. This is a precaution to make sure we don't keep the handle open longer than necessary. |
mkpankov
approved these changes
Aug 3, 2020
There was a problem hiding this comment.
Reviewed 2 of 2 files at r2.
Reviewable status:complete! all files reviewed, all discussions resolved
ip1981
approved these changes
Aug 4, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the only way to run a
remote_actionis to call it throughthe
action-runner.This means even if there is code within the
action-runnerthat wantsto call a local action it will need to schedule it via HTTPS / UDS.
As a first step to making this more efficient, move the
remote_actioncode out to a directly callable fn.
Signed-off-by: Joe Grund jgrund@whamcloud.io
This change is