Skip to content
This repository has been archived by the owner on Jul 25, 2022. It is now read-only.

Implement Create/Destroy SnapshotStep #2140

Merged
merged 5 commits into from
Aug 11, 2020
Merged

Implement Create/Destroy SnapshotStep #2140

merged 5 commits into from
Aug 11, 2020

Conversation

mkpankov
Copy link
Contributor

@mkpankov mkpankov commented Aug 7, 2020

Signed-off-by: Michael Pankov work@michaelpankov.com


This change is Reviewable

Signed-off-by: Michael Pankov <work@michaelpankov.com>
@mkpankov mkpankov requested a review from a team August 7, 2020 07:02
@mkpankov mkpankov self-assigned this Aug 7, 2020
@mkpankov mkpankov added this to the IML EX V3 milestone Aug 7, 2020
Copy link
Member

@jgrund jgrund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Create / Destroy / Mount / Unmount all need to match the structs in wire-types.

chroma_core/models/host.py Outdated Show resolved Hide resolved
chroma_core/models/host.py Outdated Show resolved Hide resolved
chroma_core/models/host.py Outdated Show resolved Hide resolved
Signed-off-by: Michael Pankov <work@michaelpankov.com>
Signed-off-by: Michael Pankov <work@michaelpankov.com>
@mkpankov mkpankov requested a review from jgrund August 10, 2020 12:18
jgrund
jgrund previously approved these changes Aug 10, 2020
@jgrund jgrund requested a review from a team August 10, 2020 15:11
chroma_core/models/host.py Outdated Show resolved Hide resolved
@jgrund jgrund requested a review from ip1981 August 10, 2020 16:48
ip1981
ip1981 previously approved these changes Aug 10, 2020
Signed-off-by: Michael Pankov <work@michaelpankov.com>
@mkpankov mkpankov dismissed stale reviews from ip1981 and jgrund via 837a375 August 11, 2020 06:47
Signed-off-by: Michael Pankov <work@michaelpankov.com>
@mkpankov mkpankov requested review from jgrund and ip1981 August 11, 2020 08:03
@jgrund jgrund merged commit 549c22d into master Aug 11, 2020
@jgrund jgrund deleted the snapshot-step branch August 11, 2020 12:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants