This repository has been archived by the owner on Jul 25, 2022. It is now read-only.
debuapi: Optionally read from stdin for Body #2149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nathaniel Clark <nclark@whamcloud.com>
jgrund
approved these changes
Aug 11, 2020
johnsonw
approved these changes
Aug 11, 2020
| let mut buf: Vec<u8> = Vec::new(); | ||
| stdin().read_to_end(&mut buf).await?; | ||
| let s = String::from_utf8_lossy(&buf); | ||
| Some(serde_json::from_str(&s)?) |
There was a problem hiding this comment.
You could probably convert the result to an option here.
serde_json::from_str(&s).ok()
There was a problem hiding this comment.
That would lose whatever the error was though
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #1832
Signed-off-by: Nathaniel Clark nclark@whamcloud.com
This change is