This repository has been archived by the owner on Jul 25, 2022. It is now read-only.
Implement entire Snapshot GraphQL API #2177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
ip1981
previously approved these changes
Aug 21, 2020
mkpankov
force-pushed
the
api
branch
2 times, most recently
from
7ea03a0
to
8d77a05
Compare
This comment has been minimized.
This comment has been minimized.
mkpankov
force-pushed
the
api
branch
2 times, most recently
from
2348393
to
4a3634f
Compare
mkpankov
changed the base branch from
master
to
ip1981/ex-1510-snap-list-daemon
ip1981
force-pushed
the
ip1981/ex-1510-snap-list-daemon
branch
from
642da95
to
6e46e1f
Compare
johnsonw
reviewed
Sep 3, 2020
jgrund
reviewed
Sep 4, 2020
This is due to us not filtering out zed events for snapshots (which also will only appear after a reboot). |
ip1981
reviewed
Sep 7, 2020
mkpankov
force-pushed
the
api
branch
2 times, most recently
from
9eb1cde
to
6edb0cd
Compare
jgrund
reviewed
Sep 8, 2020
Signed-off-by: Michael Pankov <work@michaelpankov.com>
Signed-off-by: Michael Pankov <work@michaelpankov.com>
|
Has a conflict on master, otherwise LGTM |
Signed-off-by: Michael Pankov <work@michaelpankov.com>
Signed-off-by: Michael Pankov <work@michaelpankov.com>
Signed-off-by: Michael Pankov <work@michaelpankov.com>
Signed-off-by: Michael Pankov <work@michaelpankov.com>
Signed-off-by: Michael Pankov <work@michaelpankov.com>
Signed-off-by: Michael Pankov <work@michaelpankov.com>
Signed-off-by: Michael Pankov <work@michaelpankov.com>
Signed-off-by: Michael Pankov <work@michaelpankov.com>
Signed-off-by: Michael Pankov <work@michaelpankov.com>
Signed-off-by: Michael Pankov <work@michaelpankov.com>
nlinker
approved these changes
Sep 8, 2020
There was a problem hiding this comment.
Reviewed 1 of 10 files at r1, 4 of 9 files at r3, 1 of 13 files at r4, 1 of 10 files at r5, 2 of 5 files at r10, 3 of 3 files at r11, 5 of 6 files at r13, 2 of 2 files at r14.
Reviewable status: all files reviewed, 14 unresolved discussions (waiting on @ip1981, @jgrund, @johnsonw, and @mkpankov)
jgrund
approved these changes
Sep 8, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With snapshot creation, there's issue of filesystem going
stoppedunexpectedly.With everything else, there's potential to hit this issue: https://github.com/whamcloud/integrated-manager-for-lustre/issues/2218
Signed-off-by: Michael Pankov work@michaelpankov.com
This change is