This repository has been archived by the owner on Jul 25, 2022. It is now read-only.
Add create and destroy resource #2178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
utopiabound
force-pushed
the
rust-ha-create
branch
from
d9b5aae
to
3d4b6c5
Compare
johnsonw
previously approved these changes
Aug 26, 2020
utopiabound
force-pushed
the
rust-ha-create
branch
from
3d4b6c5
to
405d718
Compare
johnsonw
reviewed
Aug 31, 2020
johnsonw
reviewed
Sep 1, 2020
|
Looks like there are a couple of clippy errors and wondering if we need to keep the comment. |
ip1981
reviewed
Sep 1, 2020
iml-agent/src/action_plugins/high_availability/fixtures/create-client-cloned.xml
Outdated
Show resolved
Hide resolved
ip1981
reviewed
Sep 1, 2020
jgrund
reviewed
Sep 1, 2020
ip1981
previously approved these changes
Sep 3, 2020
johnsonw
previously approved these changes
Sep 3, 2020
ip1981
previously approved these changes
Sep 10, 2020
jgrund
reviewed
Oct 20, 2020
jgrund
reviewed
Oct 20, 2020
jgrund
reviewed
Oct 20, 2020
jgrund
reviewed
Oct 20, 2020
jgrund
reviewed
Oct 20, 2020
jgrund
suggested changes
Oct 20, 2020
utopiabound
force-pushed
the
rust-ha-create
branch
2 times, most recently
from
6ba606f
to
72b4f2c
Compare
utopiabound
force-pushed
the
rust-ha-create
branch
from
72b4f2c
to
5d00797
Compare
utopiabound
force-pushed
the
cloned-index
branch
from
9cf8d2e
to
4af1d7b
Compare
utopiabound
force-pushed
the
rust-ha-create
branch
from
5d00797
to
0e9063f
Compare
|
Looks like this has a conflict on latest master. |
utopiabound
force-pushed
the
rust-ha-create
branch
from
a768369
to
d1be89e
Compare
Related #1464 Add ability to add cloned resources Add test for create_resource() Add cloned_client and flesh out pacemaker constraints Address review comments Start normal resources, not cloned client Account for missing templates Add destroy cloned client Add constraint ids to destroy_resource Only call umount when the mount is mounted Fix missing return Fix cloned init check and wait Rename PacemakerOperations.is_some for clarity Move crm commands to correct module Signed-off-by: Nathaniel Clark <nclark@whamcloud.com>
utopiabound
force-pushed
the
rust-ha-create
branch
from
d1be89e
to
cd68238
Compare
ip1981
reviewed
Nov 17, 2020
| cibxpath( | ||
| "delete", | ||
| &format!( | ||
| "//resources/primitive[@id=\"{}\"]/meta_attributes", |
There was a problem hiding this comment.
nit:
Suggested change
| "//resources/primitive[@id=\"{}\"]/meta_attributes", | |
| r#"//resources/primitive[@id="{}"]/meta_attributes"#, |
ip1981
approved these changes
Nov 17, 2020
johnsonw
approved these changes
Nov 17, 2020
jgrund
reviewed
Nov 17, 2020
| pub async fn create_single_resource( | ||
| (agent, constraints): (ResourceAgentInfo, Vec<ResourceConstraint>), | ||
| ) -> Result<(), ImlAgentError> { | ||
| let ids = resource_list().await?; |
There was a problem hiding this comment.
An reason read_crm_output could not be used here instead?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #1464
Signed-off-by: Nathaniel Clark nclark@whamcloud.com
This change is