Skip to content
This repository has been archived by the owner on Jul 25, 2022. It is now read-only.

Lower snapshot listing interval #2276

Merged
merged 2 commits into from
Sep 25, 2020
Merged

Lower snapshot listing interval #2276

merged 2 commits into from
Sep 25, 2020

Conversation

mkpankov
Copy link
Contributor

@mkpankov mkpankov commented Sep 25, 2020

Listing times on the agent. With 10 snapshots:

[root@mds1 vagrant]# time iml-agent snapshot list fs
{{[Snapshot
{ filesystem_name: "fs", snapshot_name: "test2", snapshot_fsname: "7941fd0f", modify_time: 2020-09-25T09:53:04Z, create_time: 2020-09-25T09:53:04Z, mounted: Some(false), comment: Some("") }
...
real 0m4.728s
user 0m0.610s
sys 0m0.408s

With 20 snapshots:

[root@mds1 vagrant]# time iml-agent snapshot list fs
[Snapshot
{ filesystem_name: "fs", snapshot_name: "test2", snapshot_fsname: "7941fd0f", modify_time: 2020-09-25T09:53:04Z, create_time: 2020-09-25T09:53:04Z, mounted: Some(false), comment: Some("") }
...
real 0m11.720s
user 0m1.571s
sys 0m0.905s

There's also some variance. For 20 snapshots, these are 5 times: 0m11.720s, 0m10.119s, 0m9.724s, 0m10.353s, 0m8.728s.

Signed-off-by: Michael Pankov work@michaelpankov.com


This change is Reviewable

Signed-off-by: Michael Pankov <work@michaelpankov.com>
@mkpankov mkpankov requested review from jgrund and a team September 25, 2020 10:36
@mkpankov mkpankov self-assigned this Sep 25, 2020
@mkpankov mkpankov added this to the IML EX V3 milestone Sep 25, 2020
@ip1981
Copy link
Member

ip1981 commented Sep 25, 2020

What about 1000? :)

I think we'll need to update the snapshot table on each snapshot event (creation, removal) anyway for better UX.

@jgrund
Copy link
Member

jgrund commented Sep 25, 2020

What about 1000? :)

Currently due to other limitations, lctl snapshot_list won't print anything past 100 snapshots.

Signed-off-by: Michael Pankov <work@michaelpankov.com>
@mkpankov mkpankov requested review from jgrund and a team September 25, 2020 13:40
@jgrund jgrund merged commit fd600df into master Sep 25, 2020
@jgrund jgrund deleted the lower branch September 25, 2020 17:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants