Implement GUI for Stratagem reports #2334
Conversation
ip1981
force-pushed
the
ip1981/ex/1897/gui/stratagem/reports
branch
2 times, most recently
from
bdec621
to
335619d
Compare
There was a problem hiding this comment.
Reviewed 7 of 7 files at r1.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @ip1981)
iml-gui/crate/src/page/stratagem/report.rs, line 45 at r1 (raw file):
SortBy(table::SortBy<SortField>), DeleteReport(String), ReportDeleted(fetch::ResponseDataResult<Response<stratagem::list_reports::Resp>>),
Why get a whole list_reports::Resp when a single report gets deleted?
iml-gui/crate/src/page/stratagem/report.rs, line 148 at r1 (raw file):
Msg::ReportDeleted(x) => { match x { Ok(Response::Data(_)) => {}
Maybe this should contain names or ids of deleted reports so we can directly purge them from the model?
It's a typo :) |
ip1981
force-pushed
the
ip1981/ex/1897/gui/stratagem/reports
branch
from
335619d
to
7839bad
Compare
Actually, it does not need to return anything but success/failure, because we already know what we delete. |
|
Maybe I should try server-side sorting. |
|
This should also allow the report to be downloaded if the user clicks the report name. Reports can be downloaded at |
|
Also, size should be in a human-readable form. |
Signed-off-by: Igor Pashev <pashev.igor@gmail.com>
ip1981
force-pushed
the
ip1981/ex/1897/gui/stratagem/reports
branch
from
7839bad
to
9345be1
Compare
We can succeed in deleting one report and not the other (I/O error for example). |
|
|
||
| pub fn view(model: &Model, session: Option<&Session>) -> Node<Msg> { | ||
| if model.rows.is_empty() { | ||
| return empty![]; |
There was a problem hiding this comment.
Since reports are currently the only thing in here, it would be nice to present a message like no reports found, or something to that effect.
| } | ||
| Msg::DeleteReport(filename) => { | ||
| if let Ok(true) = window().confirm_with_message(&format!("Delete {}?", filename)) { | ||
| let query = stratagem::delete_report::build(filename); |
There was a problem hiding this comment.
nit, it would be nice to optimistically delete the report from the model here.
Signed-off-by: Igor Pashev pashev.igor@gmail.com
This change is