Skip to content
This repository has been archived by the owner on Jul 25, 2022. It is now read-only.

Remove swap-emitter.timer #2335

Merged
merged 1 commit into from
Oct 16, 2020
Merged

Remove swap-emitter.timer #2335

merged 1 commit into from
Oct 16, 2020

Conversation

jgrund
Copy link
Member

@jgrund jgrund commented Oct 14, 2020

Due to systemd/systemd#9328, there is no way to silence a systemd timer.

To workaround this limitation, create a new daemon that will list swap
devices one per minute, but without logging each tick to the journal.

In addition, update mount-emitter to use latest futures and tokio.

Fixes #2232

Signed-off-by: Joe Grund jgrund@whamcloud.io


This change is Reviewable

@jgrund jgrund self-assigned this Oct 14, 2020
@jgrund jgrund force-pushed the remove-swap-emitter-timer branch 2 times, most recently from 1047123 to aa4303e Compare October 15, 2020 13:09
@jgrund jgrund closed this Oct 16, 2020
@jgrund jgrund deleted the remove-swap-emitter-timer branch October 16, 2020 15:27
@jgrund jgrund restored the remove-swap-emitter-timer branch October 16, 2020 15:27
@jgrund jgrund reopened this Oct 16, 2020
@jgrund jgrund marked this pull request as ready for review October 16, 2020 16:59
@jgrund jgrund requested a review from a team October 16, 2020 17:00
Due to systemd/systemd#9328, there is no way to silence a systemd timer.

To workaround this limitation, create a new daemon that will list swap
devices one per minute, but without logging each tick to the journal.

In addition, update mount-emitter to use latest futures and tokio.

Fixes #2232

Signed-off-by: Joe Grund <jgrund@whamcloud.io>
),
DevicePath(
x.remove("SOURCE")
.ok_or_else(|| Error::Missing("SOURCE"))?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't need to be _else?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wasn't sure if clippy would complain about the allocation

@jgrund jgrund merged commit d3c6b27 into master Oct 16, 2020
@jgrund jgrund deleted the remove-swap-emitter-timer branch October 16, 2020 20:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants