Skip to content
This repository has been archived by the owner on Jul 25, 2022. It is now read-only.

Switch UI to new logs GraphQL endpoint #2336

Merged
merged 58 commits into from
Oct 27, 2020
Merged

Switch UI to new logs GraphQL endpoint #2336

merged 58 commits into from
Oct 27, 2020

Conversation

mkpankov
Copy link
Contributor

@mkpankov mkpankov commented Oct 15, 2020 •
edited
Loading

Supersedes #2300

Signed-off-by: Michael Pankov work@michaelpankov.com

This change is Reviewable

@mkpankov mkpankov self-assigned this Oct 15, 2020
@mkpankov mkpankov added this to the IML EX V3 milestone Oct 15, 2020
@mkpankov mkpankov requested a review from a team October 16, 2020 11:47
@mkpankov mkpankov linked an issue Oct 16, 2020 that may be closed by this pull request
Port /log endpoint to Rust & GraphQL #2281
Closed
@mkpankov mkpankov marked this pull request as ready for review October 16, 2020 11:47
@mkpankov mkpankov mentioned this pull request Oct 16, 2020
Closed
jgrund
jgrund reviewed Oct 16, 2020
View reviewed changes
iml-wire-types/src/lib.rs Outdated Show resolved Hide resolved
jgrund
jgrund suggested changes Oct 16, 2020
View reviewed changes
Copy link
Member

@jgrund jgrund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use TryFrom instead of From

ip1981
ip1981 reviewed Oct 16, 2020
View reviewed changes
iml-api/src/graphql.rs Outdated Show resolved Hide resolved
nlinker
nlinker previously approved these changes Oct 19, 2020
View reviewed changes
@mkpankov mkpankov requested a review from nlinker October 21, 2020 08:17
@mkpankov
Implement a draft of logs endpoint
343b704 
Signed-off-by: Michael Pankov <work@michaelpankov.com>
@mkpankov
Convert the severity
d96d9f6 
Signed-off-by: Michael Pankov <work@michaelpankov.com>
@mkpankov
Convert MessageClass
b0a1168 
Signed-off-by: Michael Pankov <work@michaelpankov.com>
@mkpankov
Implement message
62ad840 
Signed-off-by: Michael Pankov <work@michaelpankov.com>
@mkpankov
Implement fqdn and tag
cae9481 
Signed-off-by: Michael Pankov <work@michaelpankov.com>
@mkpankov
Implement datetime as post-filters
175e1aa 
Signed-off-by: Michael Pankov <work@michaelpankov.com>
@mkpankov
Rework message filter using query
60ae972 
Signed-off-by: Michael Pankov <work@michaelpankov.com>
@mkpankov
Rework datetime filtering
1e5c358 
Signed-off-by: Michael Pankov <work@michaelpankov.com>
@mkpankov
Sync MessageClass
c7101d9 
Signed-off-by: Michael Pankov <work@michaelpankov.com>
@mkpankov
Remove resource_uri
1c3b665 
Signed-off-by: Michael Pankov <work@michaelpankov.com>
@mkpankov
Implement message_class and severity
e4ee72a 
Signed-off-by: Michael Pankov <work@michaelpankov.com>
@mkpankov
Document the arguments
600faae 
Signed-off-by: Michael Pankov <work@michaelpankov.com>
nlinker
nlinker previously approved these changes Oct 22, 2020
View reviewed changes
johnsonw
johnsonw previously approved these changes Oct 23, 2020
View reviewed changes
iml-graphql-queries/src/log.rs Outdated Show resolved Hide resolved
ip1981
ip1981 reviewed Oct 23, 2020
View reviewed changes
iml-api/src/graphql/mod.rs Outdated Show resolved Hide resolved
jgrund
jgrund reviewed Oct 23, 2020
View reviewed changes
Copy link
Member

@jgrund jgrund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. This looks good overall, left a few comments and then I think this will be good to land.

In addition, please remove the python API for logs as it's now replaced.

iml-api/src/graphql/mod.rs Show resolved Hide resolved
iml-api/src/graphql/mod.rs Outdated Show resolved Hide resolved
iml-api/src/graphql/mod.rs Outdated Show resolved Hide resolved
iml-api/src/graphql/mod.rs Outdated Show resolved Hide resolved
iml-api/src/graphql/mod.rs Outdated Show resolved Hide resolved
iml-api/src/graphql/mod.rs Outdated Show resolved Hide resolved
iml-api/src/graphql/mod.rs Outdated Show resolved Hide resolved
iml-api/src/graphql/mod.rs Outdated Show resolved Hide resolved
iml-graphql-queries/src/log.rs Show resolved Hide resolved
iml-wire-types/src/lib.rs Show resolved Hide resolved
@mkpankov
Default to 100 rows
5cc30f2 
Signed-off-by: Michael Pankov <work@michaelpankov.com>
@mkpankov
Fix some of review comments
4c27347 
Signed-off-by: Michael Pankov <work@michaelpankov.com>
@mkpankov
Check before filtering
4d011d6 
Signed-off-by: Michael Pankov <work@michaelpankov.com>
@mkpankov mkpankov dismissed stale reviews from johnsonw and nlinker via 4d011d6 October 26, 2020 07:59
jgrund
jgrund reviewed Oct 26, 2020
View reviewed changes
iml-wire-types/src/lib.rs Outdated Show resolved Hide resolved
jgrund
jgrund reviewed Oct 26, 2020
View reviewed changes
iml-wire-types/src/lib.rs Outdated Show resolved Hide resolved
@mkpankov
Fix clippy issues
a807a26 
Signed-off-by: Michael Pankov <work@michaelpankov.com>
@mkpankov
Move Resp
abe5b89 
Signed-off-by: Michael Pankov <work@michaelpankov.com>
@mkpankov
Remove log API and part of the class
42f283f 
Signed-off-by: Michael Pankov <work@michaelpankov.com>
@mkpankov
Remove mentions of log
1b4a82a 
Signed-off-by: Michael Pankov <work@michaelpankov.com>
@mkpankov
Remove LogResource
b46b6e3 
Signed-off-by: Michael Pankov <work@michaelpankov.com>
@mkpankov
Restore the class
97697ad 
Signed-off-by: Michael Pankov <work@michaelpankov.com>
@mkpankov
Remove tests of logs
c43236f 
Signed-off-by: Michael Pankov <work@michaelpankov.com>
@mkpankov
Remove log tests
4ec1915 
Signed-off-by: Michael Pankov <work@michaelpankov.com>
@mkpankov mkpankov requested a review from jgrund October 27, 2020 08:32
@jgrund jgrund merged commit e3ce868 into master Oct 27, 2020
@jgrund jgrund deleted the log-ui branch October 27, 2020 15:24
@nlinker nlinker restored the log-ui branch October 28, 2020 06:49
@nlinker nlinker deleted the log-ui branch October 28, 2020 06:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jgrund jgrund jgrund approved these changes

@utopiabound utopiabound utopiabound approved these changes

@ip1981 ip1981 Awaiting requested review from ip1981

@nlinker nlinker Awaiting requested review from nlinker

@johnsonw johnsonw Awaiting requested review from johnsonw

Assignees

@mkpankov mkpankov

Labels
enhancement
Projects
None yet
Milestone
IML EX V3
6 participants
@mkpankov @ip1981 @jgrund @nlinker @johnsonw @utopiabound