This repository has been archived by the owner on Jul 25, 2022. It is now read-only.
Duplicate target insert during attempted target mount #2381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When targets are mounted quickly in succession (i.e after a failed mount), we can get data
from the agents showing the target mounted on both hosts.
When this occurs we will try to insert the target twice into the db.
Instead we should filter out any items that show as mounted but are unknown to the current host.
Fixes #2380
Signed-off-by: Joe Grund <jgrund@whamcloud.io>
johnsonw
approved these changes
Nov 12, 2020
ip1981
approved these changes
Nov 13, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When targets are mounted quickly in succession (i.e after a failed mount), we can get data
from the agents showing the target mounted on both hosts.
When this occurs we will try to insert the target twice into the db.
Instead we should filter out any items that show as mounted but are unknown to the current host.
Fixes #2380
Signed-off-by: Joe Grund jgrund@whamcloud.io
This change is