This repository has been archived by the owner on Jul 25, 2022. It is now read-only.
Update docker setup #2444
Merged
Update docker setup #2444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the IML docker setup to not print output while starting. In addition, use a container that becomes stable earlier to copy settings to the host. Signed-off-by: Joe Grund <jgrund@whamcloud.io>
beevans
reviewed
Dec 19, 2020
| until /usr/bin/docker exec $service.1.$trailer /bin/bash -c 'until [ -f /var/lib/chroma/iml-settings.conf ]; do echo "Waiting for settings."; sleep 1; done'; do | ||
| echo "Waiting for container" | ||
| sleep 1 | ||
| until /usr/bin/docker exec $service.1.$trailer sh -c 'until [ -f /var/lib/chroma/iml-settings.conf ]; do echo "copy-embedded-settings: Waiting for EMF container settings..."; sleep 1; done' 2>/dev/null; do |
There was a problem hiding this comment.
I think being explicit about what shell to use is a good thing. sh is usually bash, but not always
There was a problem hiding this comment.
In this case, bash does not exist, only sh exists in this container.
There was a problem hiding this comment.
That's weird enough that it merits a comment, I think
There was a problem hiding this comment.
Ok, I can add in a follow-on
beevans
approved these changes
Dec 19, 2020
utopiabound
pushed a commit
that referenced
this pull request
Apr 5, 2021
Update the IML docker setup to not print output while starting. In addition, use a container that becomes stable earlier to copy settings to the host. Signed-off-by: Joe Grund <jgrund@whamcloud.io>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the IML docker setup to not print output while starting.
In addition, use a container that becomes stable earlier to copy
settings to the host.
Signed-off-by: Joe Grund jgrund@whamcloud.io
This change is