Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing ExtendedSymbol #25

Closed
aaroncox opened this issue Apr 2, 2022 · 2 comments
Closed

Missing ExtendedSymbol #25

aaroncox opened this issue Apr 2, 2022 · 2 comments
Milestone

Comments

@aaroncox
Copy link
Member

aaroncox commented Apr 2, 2022

We don't have types for this.

https://developers.eos.io/manuals/eosio.cdt/v1.7/classeosio_1_1extended__symbol

Unsure if we need it or if Symbol itself handles it? I'm outta my depth without some research.

@jeisses
Copy link

jeisses commented Aug 14, 2023

I was missing this type the other day. It is similar to ExtendedAsset which is provided by this library, so it would make sense if ExtendedSymbol is also there.

It's simple enough to get around this with a Struct, so nothing important. This is what I do now:

@Struct.type('extended_symbol')
class ExtendedSymbol extends Struct {
    static abiName = 'extended_symbol'
    static abiFields = [{name: 'sym', type: 'symbol'},{name: 'contract', type: 'name'}]
    constructor(sym: Asset.SymbolType, contract: NameType) {
        super({'sym': sym, 'contract': contract});
    }
}

const efx = new ExtendedSymbol('4,EFX', 'effecttokens')

@aaroncox aaroncox added this to the Unscheduled milestone Aug 18, 2023
@aaroncox
Copy link
Member Author

aaroncox commented Nov 7, 2023

Closing, more discussion here: #90

@aaroncox aaroncox closed this as completed Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

2 participants