Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extended_symbol type #90

Closed
wants to merge 1 commit into from

Conversation

benjiewheeler
Copy link

This PR adds the extended_symbol type

Simply copied from ExtendedAsset and made neccessary changes.

@aaroncox
Copy link
Member

aaroncox commented Nov 7, 2023

Based on the discussions in Telegram that started here:

https://t.me/antelopedevs/334145

This isn't a builtin, so we don't want to add it as a builtin type for the serializer - meaning it still needs to be defined currently in either the ABI or as a Struct.

As somewhat of a compromise to at least make it more accessible, I did add the type in as an exported struct here: 015df9f

Applications can leverage that as a type if need be.

I'm going to close out this PR since it won't be merged - but in the future if we hit a point where the ExtendedSymbol is added as a builtin type to the platform code, we can definitely get it added here for parity's sake.

@aaroncox aaroncox closed this Nov 7, 2023
@aaroncox aaroncox mentioned this pull request Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants