Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement support for packed transaction compression #73

Merged
merged 8 commits into from
Aug 18, 2023
Merged

Implement support for packed transaction compression #73

merged 8 commits into from
Aug 18, 2023

Conversation

aaroncox
Copy link
Member

@aaroncox aaroncox commented Aug 3, 2023 •
edited
Loading

This PR adds support for compressed packed transactions using zlib.

jnordberg
jnordberg approved these changes Aug 16, 2023
View reviewed changes
Copy link
Collaborator

@jnordberg jnordberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Pako is a pretty heavy dependency though, if this is a concern we could add it as an optionalDepenency and try to import it when a compressed transaction is encountered. On the other hand we do have pako in 99% for our projects already for ESR

@aaroncox aaroncox merged commit 3e53afe into master Aug 18, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnordberg jnordberg jnordberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aaroncox @jnordberg