Add auto-clean functionality #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handy for scripts, now you can have the convenience of always running with --clean without the overhead of always rebuilding the container. Signed-off-by: Julian Phillips <julian@quantumfyre.co.uk>
We don't really need a terminal, and might not have one. Signed-off-by: Julian Phillips <julian@quantumfyre.co.uk>
If there is a wr command available that doesn't support --auto-clean build fails, so add --auto-clean to the bootstrap check ... Signed-off-by: Julian Phillips <julian@quantumfyre.co.uk>
Now you can make auto-clean the default behaviour by enabling it in your local configuration file. If you wish to explictly not use it, then you can specify the --no-auto-clean command line option. Signed-off-by: Julian Phillips <julian@quantumfyre.co.uk>
If we remove the container because it was out of date (and removeOld was set), then we should immediately hand off to Create - as we would if the container didn't exist in the first place. Signed-off-by: Julian Phillips <julian@quantumfyre.co.uk>
Signed-off-by: Julian Phillips <julian@quantumfyre.co.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a command line option, and local config setting to enable automatic cleaning of old containers. If you call run with the --auto-clean option, or set the auto-clean local config setting to true, then any container that was built from old configuration or an old image will be removed and replaced with a new one.
This has the same functional effect as always running with --clean, except it doesn't remove the container if the config hasn't changed.