Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added iterables in flatten to item list #11

Merged
merged 2 commits into from Aug 3, 2019
Merged

Added iterables in flatten to item list #11

merged 2 commits into from Aug 3, 2019

Conversation

frruit
Copy link
Contributor

@frruit frruit commented Aug 2, 2019

From my viewpoint it's required to return lists also as a separated list.

If possible please take the change to next release so that i can use it via pip in my project :-)

@FlipperPA
Copy link
Member

I'm going to tweak this slightly, to create two separators. I just want to be sure we're not relying on the "." separator anywhere else in the code.

@FlipperPA FlipperPA merged commit 5574ae4 into wharton:master Aug 3, 2019
@FlipperPA
Copy link
Member

@frruit Would you like me to add your name to the Contributors, or just ffruit?

@FlipperPA
Copy link
Member

@frruit I've merged the changed and tweaks to master. Can you test off the master branch and make sure this works as your expected? I added a second separator for lists, so we don't affect the existing behavior for other data types. If it is all good, I'll get this released to PyPI.

@frruit
Copy link
Contributor Author

frruit commented Aug 8, 2019

@FlipperPA if you want then please add me as a contributor. My name is Franjo Rupcic and thanks for the offer.

I cannot test it currently because i'm on vacation and my laptop is not with me. From my viewpoint you can release it because it's enhancement but i'll give you more feedback when i'm start to work again with it. At the moment I think that the user of you mixin class should be able to overwrite the seperator from outside the library. Something like the configuration of the filename via the mixin class.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants