Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add get_filename method #14

Closed
notanumber opened this issue Oct 25, 2019 · 4 comments
Closed

Add get_filename method #14

notanumber opened this issue Oct 25, 2019 · 4 comments

Comments

@notanumber
Copy link

Would it make sense to mirror how most of the DRF & Django's CBVs work by having a get_ method for get_filename that would allow a user to dynamically set the filename when using the XLSXFileMixin?

Maybe as simple as:

def get_filename(self):
    return self.filename
@FlipperPA
Copy link
Member

Great idea! Can you give this branch a whirl and see if it works for ya?

https://github.com/wharton/drf-renderer-xlsx/tree/feature/get-filename-method

@FlipperPA
Copy link
Member

BTW, you are @notanumber, you are a free man! 🔢

@FlipperPA
Copy link
Member

This has been published to PyPI as version 0.3.5.

@notanumber
Copy link
Author

Looks good, thanks! I'll upgrade and give it a whirl shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants