fixes a bug that caused loss of ancestor of parent field in _flatten_… #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@paveloder I've merged in your pull request along with #35, which created a conflict between them. I think I've sorted out both properly, but could you please run a test against the latest on the |
|
@FlipperPA looks like problem is fixed now, the example data now renders correctly. Thanks. |
|
Thanks for the PR! This has been released in version 0.4.1: https://pypi.org/project/drf-renderer-xlsx/0.4.1/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a problem that happened while flattening headers from nested serialisers. Example response:
{ "address": { "client": { "name": "foo", "id": 1 } }Renderer put only client.name and client.id to header names. And returned empty data for those fields. This PR fixes this.