Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usage of depreciated NullBooleanField for drf 3.14.0 #65

Merged
merged 1 commit into from Sep 30, 2022

Conversation

sarahboyce
Copy link
Contributor

@sarahboyce sarahboyce commented Sep 23, 2022

There is a new drf release https://www.django-rest-framework.org/community/release-notes/#3140
Here NullBooleanField is no longer available and so I removed the one reference to allow support for drf 3.14.0

It was also not required as the isinstance(field, BooleanField) would return true for a NullBooleanFIeld due to object inheritance:

>>> from rest_framework.fields import NullBooleanField
>>> field = NullBooleanField()
>>> from rest_framework.fields import BooleanField
>>> isinstance(field, BooleanField)
True
>>> 

So I think we should be good 馃憤

Thank you for the package 鉂わ笍 @FlipperPA

@FlipperPA
Copy link
Member

Thank you, @sarahboyce - I will take a look at this today.

@sarahboyce
Copy link
Contributor Author

Thank you @FlipperPA 馃帀
Let me know if you need anything from me 馃憤

@FlipperPA FlipperPA merged commit d4f1a36 into wharton:main Sep 30, 2022
@FlipperPA
Copy link
Member

Thank you, @sarahboyce!

@FlipperPA
Copy link
Member

Thank you! This has been published to PyPI at 2.2.0:

https://github.com/wharton/drf-excel/releases/tag/2.2.0

https://pypi.org/project/drf-excel/2.2.0/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants