Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ft show xdsm #21

Merged
merged 4 commits into from
Jun 18, 2021
Merged

Ft show xdsm #21

merged 4 commits into from
Jun 18, 2021

Conversation

relf
Copy link
Collaborator

@relf relf commented Jun 18, 2021

Generate standalone HTML page without logging in

@relf relf merged commit 40335bf into whatsopt:master Jun 18, 2021
@christophe-david
Copy link

Thank you for this great feature, but I am sorry to tell you that you just killed FAST-OAD. 😆

Actually, the constant you renamed is imported (too) early in FAST-OAD, and not having it breaks it.
Not a big deal, we will learn our lesson and adapt our code, but I am more concerned about your change in generate_xdsm_html() that now requires a file. It was very convenient for us to feed WhatsOpt on-the-fly with the OpenMDAO problem that we generated.

I understand that you have now to provide the problem to generate_xdsm_html(), but could it be a Problem instance instead of a file ?

@relf relf deleted the ft-show-xdsm branch June 21, 2021 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants